This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
platform: how to establish peering connection between Aiven and UpCloud #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojcik-dorota
changed the title
platform: how to establish peering connection between Aiven and UpCloud
[WiP] platform: how to establish peering connection between Aiven and UpCloud
Sep 28, 2023
Deploying with Cloudflare Pages
|
wojcik-dorota
changed the title
[WiP] platform: how to establish peering connection between Aiven and UpCloud
platform: how to establish peering connection between Aiven and UpCloud
Sep 29, 2023
giacomo-alzetta-aiven
previously requested changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The view on the peering list was updated recently so point 6 in "Aiven VPC network UUID" needs to be updated. Some other minor notes.
In general the instructions look correct to me 👍
wojcik-dorota
dismissed
giacomo-alzetta-aiven’s stale review
October 3, 2023 18:35
comments addressed
giacomo-alzetta-aiven
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will give @sjamgade some time to look at this too before merging.
sjamgade
approved these changes
Oct 4, 2023
this should probably have been a squash and merge, |
@sjamgade we don't have a strict squashing policy in devportal so all good :-) Thank you!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://aiven.atlassian.net/browse/DOC-526